Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: use symbolic name in go-version #314

Merged
merged 1 commit into from
Aug 24, 2023
Merged

workflows: use symbolic name in go-version #314

merged 1 commit into from
Aug 24, 2023

Conversation

phlogistonjohn
Copy link
Collaborator

@phlogistonjohn phlogistonjohn commented Aug 15, 2023 •
edited
Loading

Depends on: #313
Depends on: #288

The workflow files that use Go directly (as opposed to inside a container) use actions/setup-go - this action gained an ability to use "relative versions" of stable and oldstable in the last year or two.

Switch our workflow file to use oldstable rather than a specific version number in order to keep up with releases from Go upstream. Use oldstable as to ensure the older but still actively maintained version of Go works.

This doesn't handle the container image... that's a WIP project for another PR.

@phlogistonjohn phlogistonjohn marked this pull request as draft August 15, 2023 14:55
@dpulls
Copy link

dpulls bot commented Aug 21, 2023

🎉 All dependencies have been resolved !

@mergify
Copy link

mergify bot commented Aug 21, 2023

This pull request now has conflicts with the target branch. Please resolve these conflicts and force push the updated branch.

@obnoxxx
Copy link
Collaborator

obnoxxx commented Aug 21, 2023

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Aug 21, 2023

rebase

❌ Base branch update has failed

Git reported the following error:

warning: skipped previously applied commit be235b3
warning: skipped previously applied commit 4dc447b
warning: skipped previously applied commit 4c945b9
hint: use --reapply-cherry-picks to include skipped commits
hint: Disable this message with "git config advice.skippedCherryPicks false"
Rebasing (1/2)
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git rebase --skip'
interactive rebase in progress; onto d28e94b
Last command done (1 command done):
   pick d3e0266 build: Bump Go version to 1.19
Next command to do (1 remaining command):
   pick 7c39826 workflows: use symbolic name oldstable instead of a particular version
  (use "git rebase --edit-todo" to view and edit)
You are currently rebasing branch 'jjm-go-vers' on 'd28e94b'.
  (all conflicts fixed: run "git rebase --continue")

nothing to commit, working tree clean
Could not apply d3e0266... build: Bump Go version to 1.19

err-code: 06DC6

@dpulls
Copy link

dpulls bot commented Aug 23, 2023

🎉 All dependencies have been resolved !

@phlogistonjohn
workflows: use symbolic name oldstable instead of a particular version
dc7385f 
The actions/setup-go action has supported symbolic names of `stable` and
`oldstable` for a bit. Instead of having to constantly update the
workflow every time Go does a new release use the `oldstable` keyword in
our workflow so that we're always testing with the older stable release
of Go. We choose the older stable version because we do not want to
accidentally introduce something new that requires a feature of the
newer Go release.

Signed-off-by: John Mulligan <[email protected]>
@phlogistonjohn phlogistonjohn changed the title [WIP] use symbolic name in go-version workflows: use symbolic name in go-version Aug 23, 2023
@phlogistonjohn phlogistonjohn marked this pull request as ready for review August 23, 2023 14:35
synarete
synarete approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlogistonjohn phlogistonjohn mentioned this pull request Aug 23, 2023
Merged
anoopcs9
anoopcs9 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool.

@mergify mergify bot merged commit 09f0fa0 into samba-in-kubernetes:master Aug 24, 2023
12 checks passed
@mergify mergify bot added the priority-review This PR deserves a look label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synarete synarete synarete approved these changes

@anoopcs9 anoopcs9 anoopcs9 approved these changes

@obnoxxx obnoxxx Awaiting requested review from obnoxxx

Assignees
No one assigned
Labels
priority-review This PR deserves a look
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phlogistonjohn @obnoxxx @anoopcs9 @synarete